Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move errorx/errorxpb dependency to mimir-proxies #67

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

alexgreenbank
Copy link
Contributor

Following on from grafana/mimir-proxies#12 which imported the errorx and errorxpb libs from influx2cortex into mimir-proxies we can now remove these packages from the influx2cortex repo and source them from mimir-proxies.

go mod vendor and go mod tidy for good measure.

@alexgreenbank alexgreenbank requested a review from a team September 28, 2022 16:12
@grafanabot
Copy link

Go coverage report:

Click to expand.
File %
github.com/grafana/influx2cortex/pkg/influx/api.go 93.3%
github.com/grafana/influx2cortex/pkg/influx/errors.go 100.0%
github.com/grafana/influx2cortex/pkg/influx/parser.go 84.7%
github.com/grafana/influx2cortex/pkg/influx/proxy.go 61.9%
github.com/grafana/influx2cortex/pkg/influx/recorder.go 91.7%
github.com/grafana/influx2cortex/pkg/route/registerer.go 100.0%
github.com/grafana/influx2cortex/pkg/tenant/resolver.go 75.6%
github.com/grafana/influx2cortex/pkg/tenant/tenant.go 91.7%
github.com/grafana/influx2cortex/pkg/util/extract_forwarded.go 66.7%
github.com/grafana/influx2cortex/pkg/util/http.go 0.0%
github.com/grafana/influx2cortex/pkg/util/log/log.go 0.0%
github.com/grafana/influx2cortex/pkg/util/log/rate_limit.go 90.0%
github.com/grafana/influx2cortex/pkg/util/log/wrappers.go 0.0%
total 57.2%

Go lint report:

No issues found. 😎

Copy link
Contributor

@carrieedwards carrieedwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexgreenbank alexgreenbank merged commit 2aa237b into main Sep 29, 2022
@alexgreenbank alexgreenbank deleted the alexg/remove-errorx-packages-1 branch September 29, 2022 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants