New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reliance on local pkg/util/log #70

Merged

alexgreenbank merged 6 commits into main from alexg/remove-util-log-1

Oct 3, 2022

Contributor

alexgreenbank commented Oct 3, 2022

It was temporarily included before mimir had been released, but is unnecessary anyway.


          Remove reliance on local pkg/util/log

faff25f

alexgreenbank requested a review from a team

October 3, 2022 17:20

This comment has been minimized.

Sign in to view


          Keep linter happy

529b197

This comment has been minimized.

Sign in to view


          Update README.md item

This comment has been minimized.

Sign in to view

Contributor Author

alexgreenbank commented Oct 3, 2022

Hmm, this removes the extra logging wrappers, will look at adding them back in. Will compare with usage in mimir-proxies first.

alexgreenbank changed the title ~~Remove reliance on local pkg/util/log~~ Remove reliance on local pkg/util/log (ON HOLD)


          Add caller info to logging

cddd81d

This comment has been minimized.

Sign in to view

Contributor Author

alexgreenbank commented Oct 3, 2022

Logging of {traceID,orgID,userID,path} all handled by pkg/influx/api.go.

Added caller= logging info.

alexgreenbank changed the title ~~Remove reliance on local pkg/util/log (ON HOLD)~~ Remove reliance on local pkg/util/log

npazosmendez approved these changes

View reviewed changes


          pkg/tenant no longer used now

904c301

This comment has been minimized.

Sign in to view


          Removed unused pkg/util files.

697b3b2

grafanabot commented Oct 3, 2022

Go coverage report:

Click to expand.

File	%
github.com/grafana/influx2cortex/pkg/influx/api.go	93.3%
github.com/grafana/influx2cortex/pkg/influx/errors.go	100.0%
github.com/grafana/influx2cortex/pkg/influx/parser.go	84.7%
github.com/grafana/influx2cortex/pkg/influx/proxy.go	61.9%
github.com/grafana/influx2cortex/pkg/influx/recorder.go	91.7%
total	84.3%

Go lint report:

No issues found. 😎

alexgreenbank merged commit ee0416d into main

alexgreenbank deleted the alexg/remove-util-log-1 branch

October 3, 2022 21:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment