Move server init into influx pkg #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesusvazquez
approved these changes
Mar 1, 2022
ywwg
reviewed
Mar 2, 2022
| ) | ||
|
|
||
| // Register flags. | ||
| flag.BoolVar(&enableAuth, "auth.enable", true, "enable X-Scope-OrgId header") |
There was a problem hiding this comment.
As a rule, libraries should never define flags, only binaries should do that. Instead, all setup should be done programmatically, possibly with a config struct. the outermost binary can define flags as needed. Can you create a followup PR that moves the flags out of the library and into the binary?
There was a problem hiding this comment.
I approved this but also Agree with @ywwg 's comment.
You can mirror how other projects like query-tee https://github.com/cortexproject/cortex/blob/master/cmd/query-tee/main.go#L17-L31 does it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves most of the logic for starting up a server from the
mainpackage to theinfluxpackage.