This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Respect $range
in variable evaluation requests
#26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@davkal PTAL |
LGTM, I will test this tomorrow and try to get it merged. |
@jtlisi any progress on this? |
@jtlisi humble bump |
Anyone? |
@davkal PTAL |
@jtlisi Still working on this? |
I think we need @briangann |
Lgtm. What is missing to get this merged? /cc @daniellee |
@daniellee any chance for it to get merged within this year? :) |
@zarbis -- I am going to try to release this in ~1 week. If there is anything else you are looking at I will have to time to focus on it next week |
@ryantxu any progress on this? |
srclosson
approved these changes
Oct 10, 2019
Merged into master. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike InfluxQL, Flux allows extracting tag values for specific time range. Right now it's impossible to utilize this feature in Grafana since
$range
in request like this:is always expanded into hard-coded
start: -1h
.It leads to confusing and hard-to-pinpoint inconsistencies. For example:
Last 7 days
This happens due to event types are retrieved from Grafana variable, populated by Flux query. This PR makes Grafana to template correct time range into variable query.