better edge auth test #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantxu
reviewed
Jul 29, 2021
pkg/sitewise/auth_test.go
Outdated
Comment on lines
165
to
169
| type AuthRequest struct { | ||
| Username string `json:"username,omitempty"` | ||
| Password string `json:"password,omitempty"` | ||
| AuthMechanism string `json:"authMechanism,omitempty"` | ||
| } |
There was a problem hiding this comment.
if this is useful in the test... maybe use it in the real function?
ryantxu
reviewed
Jul 29, 2021
pkg/sitewise/auth_test.go
Outdated
Comment on lines
116
to
118
| resp["accessKeyId"] = "YEWZb5yVBl9llM9TQvn10hD4wmXKlUCNgXeCQY5YmssV55FzAFZgcta2FUw8lIcz" | ||
| resp["secretAccessKey"] = "2wH5XvUVv2FKIxvvj3YNCblvMJkI67KbXZV6ZHiy2w16LPXZboZkYvCZymsyLFiW" | ||
| resp["sessionToken"] = "glPPiSJwMx3iDuLm5BsVJVA0t5wXVhMNHFyaOkh68yz48V9rcRjRke6nJG4ErwFh" |
There was a problem hiding this comment.
just to avoid doubt -- can you make these invalid strings?
resp["accessKeyId"] = "dummyAccessKeyYEWZb5yVBl9llM9T..."
ryantxu
reviewed
Jul 29, 2021
pkg/sitewise/auth_test.go
Outdated
| } | ||
|
|
||
| //helper function to create a certificate from a template and public key plus a parent certificate and private key | ||
| func CreateCert(template, parent *x509.Certificate, pub interface{}, parentPriv interface{}) ( |
There was a problem hiding this comment.
Suggested change
| func CreateCert(template, parent *x509.Certificate, pub interface{}, parentPriv interface{}) ( | |
| func createCert(template, parent *x509.Certificate, pub interface{}, parentPriv interface{}) ( |
keep private unless required
ryantxu
reviewed
Jul 29, 2021
pkg/sitewise/auth_test.go
Outdated
| } | ||
|
|
||
| // generate a certificate template for the test server TLS | ||
| rootCertTmpl, err := CertTemplate() |
There was a problem hiding this comment.
to keep the test clear.... can you move in all the explicit (dummy/test) settings into the function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #101 (comment)