Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make asset descriptions optional #123

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Make asset descriptions optional #123

merged 1 commit into from
Apr 5, 2022

Conversation

ryantxu
Copy link
Member

@ryantxu ryantxu commented Mar 31, 2022

Fixes #122

Currently when descriptions are missing, the query can crash -- this makes all descriptions optional

@atifali
Copy link
Contributor

atifali commented Apr 5, 2022

so tested this out locally:

created model with no description
Screen Shot 2022-04-05 at 12 05 09 PM

on the current version of the plugin - can confirm we get the internal 500 as described in the issue
Screen Shot 2022-04-05 at 12 07 34 PM

with this change looks like we do see the list - which includes the model with no description as well
Screen Shot 2022-04-05 at 12 20 41 PM

Copy link
Contributor

@atifali atifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - merging now

@atifali atifali merged commit 82357ea into main Apr 5, 2022
@atifali atifali deleted the avoid-npe branch April 5, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panel does not show the list of asset models when an asset model has no description
2 participants