Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/remove from project #165

Merged
merged 3 commits into from
Feb 10, 2023
Merged

Fix/remove from project #165

merged 3 commits into from
Feb 10, 2023

Conversation

idastambuk
Copy link
Contributor

@idastambuk idastambuk commented Feb 10, 2023 •
edited

What this PR does / why we need it:

  1. Adds the type "unlabeled" so it triggers the removeFromProject action
  2. Removes feature request issue type (moved to discussions)
  3. Improves bug report

@idastambuk idastambuk requested a review from a team as a code owner February 10, 2023 10:14
@idastambuk idastambuk requested review from sarahzinger and kevinwcyu and removed request for a team February 10, 2023 10:14
@github-actions
Copy link

Backend code coverage report for PR #165
No changes

@github-actions
Copy link

Frontend code coverage report for PR #165
No changes

@github-actions
Copy link

github-actions bot commented Feb 10, 2023 •
edited

Levitate is-compatible report:

🔍 Resolving @grafana/data@latest...
🔍 Resolving @grafana/ui@latest...
🔍 Resolving @grafana/runtime@latest...
🔍 Resolving @grafana/e2e-selectors@latest...

🔬 Checking compatibility between ./src/module.ts and @grafana/data@9.3.6...
✔ Found @grafana/data version 9.2.5 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/ui@9.3.6...
✔ Found @grafana/ui version 9.2.5 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/runtime@9.3.6...
✔ Found @grafana/runtime version 9.2.5 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/e2e-selectors@9.3.6...
✔ Found @grafana/e2e-selectors version 9.2.5 locally

✔️ ./src/module.ts appears to be compatible with @grafana/data,@grafana/ui,@grafana/runtime,@grafana/e2e-selectors

aangelisc
aangelisc approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@aangelisc aangelisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @idastambuk, I'll look at updating our other plugins accordingly!

@idastambuk idastambuk merged commit 3e82711 into main Feb 10, 2023
@idastambuk idastambuk deleted the fix/removeFromProject branch February 10, 2023 13:20
@fridgepoet fridgepoet mentioned this pull request Feb 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fridgepoet fridgepoet fridgepoet approved these changes

@aangelisc aangelisc aangelisc approved these changes

@sarahzinger sarahzinger Awaiting requested review from sarahzinger sarahzinger is a code owner automatically assigned from grafana/aws-datasources

@kevinwcyu kevinwcyu Awaiting requested review from kevinwcyu kevinwcyu is a code owner automatically assigned from grafana/aws-datasources

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@idastambuk @fridgepoet @aangelisc