Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set property alias and query type to have interactive tooltips #180

Merged
merged 1 commit into from
May 3, 2023
Merged

Set property alias and query type to have interactive tooltips #180

merged 1 commit into from
May 3, 2023

Conversation

katebrenner
Copy link
Contributor

Closes #170 and does the same for query type InlineField

@katebrenner katebrenner requested a review from a team as a code owner May 2, 2023 18:13
@katebrenner katebrenner requested review from idastambuk and kevinwcyu and removed request for a team May 2, 2023 18:13
@github-actions
Copy link

github-actions bot commented May 2, 2023 •
edited

Levitate is-compatible report:

🔍 Resolving @grafana/data@latest...
🔍 Resolving @grafana/ui@latest...
🔍 Resolving @grafana/runtime@latest...
🔍 Resolving @grafana/e2e-selectors@latest...

🔬 Checking compatibility between ./src/module.ts and @grafana/data@9.5.1...
✔ Found @grafana/data version 9.2.5 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/ui@9.5.1...
✔ Found @grafana/ui version 9.2.5 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/runtime@9.5.1...
✔ Found @grafana/runtime version 9.2.5 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/e2e-selectors@9.5.1...
✔ Found @grafana/e2e-selectors version 9.2.5 locally

✔️ ./src/module.ts appears to be compatible with @grafana/data,@grafana/ui,@grafana/runtime,@grafana/e2e-selectors

@github-actions
Copy link

github-actions bot commented May 2, 2023

Backend code coverage report for PR #180
No changes

@github-actions
Copy link

github-actions bot commented May 2, 2023

Frontend code coverage report for PR #180

Plugin Main PR Difference
src 6.97% 6.97% 0%

iwysiu
iwysiu approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@iwysiu iwysiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@katebrenner katebrenner merged commit 9ea9528 into main May 3, 2023
5 checks passed
@katebrenner katebrenner deleted the interactive_tooltiops branch May 3, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwysiu iwysiu iwysiu approved these changes

@idastambuk idastambuk Awaiting requested review from idastambuk idastambuk is a code owner automatically assigned from grafana/aws-datasources

@kevinwcyu kevinwcyu Awaiting requested review from kevinwcyu kevinwcyu is a code owner automatically assigned from grafana/aws-datasources

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set Property Alias field to be interactive
2 participants
@katebrenner @iwysiu