Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow query by property alias #99

Merged
merged 10 commits into from
Aug 30, 2021
Merged

Allow query by property alias #99

merged 10 commits into from
Aug 30, 2021

Conversation

ryantxu
Copy link
Member

@ryantxu ryantxu commented Jul 8, 2021

Fixes #98

This adds propertyAlias to the UI and query model for anything that accept it

image

Still totally untested since I don't know any real alias values to try :)

@atifali
Copy link
Contributor

atifali commented Jul 15, 2021

We have currently hardcoded the AssetProperty for this case that is used to form the frames in the backend. Will only work for floats as of now:

if propertyAlias != "" {

@atifali
Copy link
Contributor

atifali commented Aug 5, 2021

this is one ad-hoc way to infer the dataType:

property.AssetProperty.DataType = aws.String(getPropertyVariantValueType(p.AssetPropertyValueHistory[0].Value))

not ideal but works for now - will be nice to have the DescribeAssetProperty end-point working with propertyAlias only, and that way we could actually have all the other descriptions too - see: #98 (comment)

@ryantxu
Copy link
Member Author

ryantxu commented Aug 13, 2021

@atifali -- looks good! Since I created the issue, I can not approve it :)

@atifali atifali marked this pull request as ready for review August 13, 2021 16:58
@atifali atifali requested a review from sunker August 13, 2021 18:27
Copy link
Contributor

@atifali atifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see: #98

@atifali atifali merged commit 72f39a6 into main Aug 30, 2021
@atifali atifali deleted the with-alias branch August 30, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support propertyAlias to fetch data
2 participants