feat: parse line numbers to pprof #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korniltsev
force-pushed
the
linenumbers
branch
from
9cbe6df
to
111191a
Compare
korniltsev
commented
Jan 18, 2024
| for _, label := range labels { | ||
| if labelsCtx != nil && labelsSnapshot != nil { | ||
| sample.Label = make([]*profilev1.Label, 0, len(labelsCtx.Labels)) | ||
| for k, v := range labelsCtx.Labels { //todo iterating over map is not deterministic, this can break tests and maybe even affect performance |
There was a problem hiding this comment.
TODO: discuss if it is bad for stoarge
There was a problem hiding this comment.
We do not assume any particular order of labels at ingestion time and always sort them explicitly in the distributor https://github.com/grafana/pyroscope/blob/main/pkg/distributor/distributor.go#L270
There was a problem hiding this comment.
I think these are different labels. Distributor sorts series labels. These are sample labels.
There was a problem hiding this comment.
Yep, sample labels are sorted as well – at normalisation we drop duplicate samples based on their stacks and labels (ignoring numeric ones)
There was a problem hiding this comment.
ah, ok. Im probably overthinking it. Thanks
kolesnikovae
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.