-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jfrparser-cli: add cli that formats json #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you put the file next to the jfr file?
cmd/jfrparser/main.go
Outdated
Format(*parser.Parser) ([]byte, error) | ||
} | ||
|
||
// TODO: mov jfr2pprof here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add pprof here and remove jfr2pprof ? we don't need two converters
cmd/jfrparser/format/format_json.go
Outdated
|
||
func (f *formatterJson) appendInit(p *parser.Parser) error { | ||
var err error | ||
f.outBuf = append(f.outBuf, []byte("[{\"Header\":")...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this json building manual?
@korniltsev addressed comments and more |
No description provided.