-
Notifications
You must be signed in to change notification settings - Fork 21
Conversation
For crossplatform environment variables in npm scripts.
For parsing JMeter JMX file XML.
Enables intercepting imports in tests.
The |
Good stuff! I'll do a second review tomorrow. |
Multiple stepping courses would reuse VU numbers. Running standard thread groups after a stepping course would also cause reuse (eg step up to 50 then down to 0, standard threads now reuse 1-50). As branching to the correct logic uses VU number, this would cause collisions in the branching logic. This patch constrains to max 1 stepping course and forces it to order after all standard thread groups.
Sorry for the delay. Have now done a second pass after your fixes, found some more issues: General
as I got: If controller
Stepping thread group
|
Thanks for that. Have updated all of it. Not sure what caused Babel requirement, but I added it as a dependency. The only package I've added to
I think this piece is following JMeter. The
(Expression here meaning a JMeter expression). If you uncheck that flag then it's meant to be JavaScript, and it should render with an eval.
I think this one is correct. Processors and assertions are supposed to apply to all descendants of the parent element. So it caches them up in the context and duplicates for all samplers in that section of the tree. |
It looks like that Babel requirement comes from
That package is used by |
Ah, you're right about the Regarding the post processors and assertions you're also correct that they apply to all samplers in the same scope. Think I found another issue here though:
|
Think I know just where I did this. Looking into it. |
Only necessary in generated code. Installed by bundle instead.
Not what I thought it was, but I've just pushed a fix. |
Ok @bookmoons. I've looked through the code as well and I think it looks good; structure, style and tests. Well done, thanks for your work on this 👏Now, go claim the bounty! PS. I sent you a message on k6 slack if you can have a look when you get a chance. |
Very nice, thank you very much. Submitted a claim and will open slack. |
Adds v1 implementation of the converter. Converts all elements listed in #1.
Closes #1.