Fallback to configurations.JPath paths even on tanka jpath.Resolve() hit #108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some scenarios tanka's jpath.Resolve() method will return false-positive results. Example:
From vscode:
The problem is that the language server incorrectly identifies
github.com/grafana/grafonnet/gen/grafonnet-latest/
as a root directory because of the jsonnsetfile.json there (code), then returns two guesses for import paths that don't exist:grafonnet-latest/{lib,vendor}/
. In this scenario it doesn't include the configured jsonnet library paths as a fallback (presumably since it thinks it found a successful hit).This change doesn't fix this resolve error, but it does append
configuration.JPaths
to the end ofOpts.ImportPaths
as a fallback for this false-positive scenario.