Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to update the Nix flake derivation #22

Merged
merged 3 commits into from
Jan 11, 2022
Merged

Conversation

jdbaldry
Copy link
Member

Signed-off-by: Jack Baldry jack.baldry@grafana.com

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
@julienduchesne
Copy link
Member

Is this something we could automate in the release workflow? https://github.com/grafana/jsonnet-language-server/blob/main/.github/workflows/release.yml

@jdbaldry
Copy link
Member Author

Yeah I imagine we could write some glue for this. If time permits, I'll look at that today.

This PATH export was useful when it was a solo project but is more
dangerous than it's worth now.

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
@jdbaldry
Copy link
Member Author

So as I sat down to do this, I realized that we would really want the file to be updated and committed before the tag push that triggers the workflow. I've codified the steps for updating the Nix derivation but it still requires the nix command line tool to run.

Copy link
Member

@julienduchesne julienduchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So as I sat down to do this, I realized that we would really want the file to be updated and committed before the tag push that triggers the workflow. I've codified the steps for updating the Nix derivation but it still requires the nix command line tool to run.

That's fine. As long as it's documented 🙂. We can merge I'd like to try it out on a release tomorrow, if that's OK (I have 0.18 and some other fixes pending release already)

@jdbaldry
Copy link
Member Author

Coolio! I realize that without prior use of Nix, this is a little awkward. Ping me if you have any difficulties.

@jdbaldry jdbaldry merged commit ebcf5d8 into main Jan 11, 2022
@julienduchesne julienduchesne deleted the jdb/2022-01-releases branch September 7, 2022 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants