Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that all files are jsonnetfmted #26

Merged
merged 3 commits into from
Feb 10, 2022

Conversation

julienduchesne
Copy link
Member

The Github action will first format then check if there is a git diff

@julienduchesne julienduchesne force-pushed the julienduchesne/add-jsonnetfmt-test branch from 32c440b to 71afeef Compare February 9, 2022 18:07
The Github action will first format then check if there is a git diff
@julienduchesne julienduchesne force-pushed the julienduchesne/add-jsonnetfmt-test branch from 71afeef to 8fc8f1c Compare February 9, 2022 18:10
@julienduchesne julienduchesne marked this pull request as ready for review February 9, 2022 18:12
@julienduchesne
Copy link
Member Author

See first commit for a failure example

@julienduchesne
Copy link
Member Author

Dang, all test locations are busted now. Will fix tests

Copy link
Contributor

@zzehring zzehring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julienduchesne julienduchesne merged commit 8c9b964 into main Feb 10, 2022
@julienduchesne julienduchesne deleted the julienduchesne/add-jsonnetfmt-test branch February 10, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants