Full multiple definitions support #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some references to vars and self were lost along the way This works for most use cases now There's still some refactoring done, both for performance and for cleanliness (lots of repeated code) but it all works now I will add a video on the README once this is merged Closes #6
julienduchesne
commented
Feb 18, 2022
| @@ -134,18 +149,11 @@ func FindRangesFromIndexList(stack *nodestack.NodeStack, indexList []string, vm | |||
| for _, fieldNode := range fieldNodes { | |||
| switch fieldNode := fieldNode.(type) { | |||
| case *ast.Var: | |||
| // If the field is a var, we need to find the value of the var | |||
| // To do so, we get the stack where the var is used and search that stack for the var's definition | |||
| varFileNode, _, _ := vm.ImportAST("", fieldNode.LocRange.FileName) | |||
There was a problem hiding this comment.
This code was moved to its own function
zzehring
approved these changes
Feb 18, 2022
Co-authored-by: Zack Zehring <zack.zehring@grafana.com>
julienduchesne
deleted the
julienduchesne/final-support-multiple-defs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some references to vars and self were lost along the way
This works for most use cases now
There's still some refactoring done, both for performance and for cleanliness (lots of repeated code) but it all works now
I will add a video on the README once this is merged
Closes #6