Add benchmark test for "go to definition" #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to refactor this code a bit but it'll be nice to see if the new code is faster This extracts the test cases and uses them for both testing and benchmarking To benchmark the code: 1. Run benchmark with the old code: `go test ./... -bench "BenchmarkDefinition/test_goto_definition_for_var_myvar" -count=10 > old.txt` 2. Modify the code 3. Run benchmark again: `go test ./... -bench "BenchmarkDefinition/test_goto_definition_for_var_myvar" -count=10 > new.txt` 4. Compare files: `benchstat old.txt new.txt`
julienduchesne
commented
Feb 24, 2022
| name string | ||
| filename string | ||
| position protocol.Position | ||
| type definitionTestCase struct { |
There was a problem hiding this comment.
Click on Hide whitespace when reviewing this file. There are no changes to the test cases
julienduchesne
added a commit
that referenced
this pull request
Feb 28, 2022
* Add benchmark test for "go to definition" I want to refactor this code a bit but it'll be nice to see if the new code is faster This extracts the test cases and uses them for both testing and benchmarking To benchmark the code: 1. Run benchmark with the old code: `go test ./... -bench "BenchmarkDefinition/test_goto_definition_for_var_myvar" -count=10 > old.txt` 2. Modify the code 3. Run benchmark again: `go test ./... -bench "BenchmarkDefinition/test_goto_definition_for_var_myvar" -count=10 > new.txt` 4. Compare files: `benchstat old.txt new.txt` * nolint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to refactor this code a bit but it'll be nice to see if the new code is faster
This extracts the test cases and uses them for both testing and benchmarking
To benchmark the code:
go test ./... -bench "BenchmarkDefinition/test_goto_definition_for_var_myvar" -count=10 > old.txtgo test ./... -bench "BenchmarkDefinition/test_goto_definition_for_var_myvar" -count=10 > new.txtbenchstat old.txt new.txt