Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring + Speed improvements #36

Merged
merged 3 commits into from
Mar 14, 2022
Merged

Refactoring + Speed improvements #36

merged 3 commits into from
Mar 14, 2022

Conversation

julienduchesne
Copy link
Member

Removed unnecessary return values in node stack
Added an import cache bringing some performance improvements

Ran some benchmarks. Pretty good improvement 馃槃

name                                                             old time/op  new time/op  delta
Definition/goto_deeply_nested_imported_attribute-8                162碌s 卤13%    12碌s 卤 6%  -92.57%  (p=0.000 n=20+20)
Definition/goto_deeply_nested_imported_attribute_through_self-8   166碌s 卤10%    48碌s 卤 9%  -71.35%  (p=0.000 n=20+20)

@julienduchesne
Refactoring + Speed improvements
1737102 
Removed unnecessary return values in node stack
Added an import cache bringing massive perfomance improvements
zzehring
zzehring reviewed Mar 14, 2022
View reviewed changes
Copy link
Contributor

@zzehring zzehring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! One comment with question.

pkg/processing/top_level_objects.go Outdated Show resolved Hide resolved
@julienduchesne julienduchesne merged commit 9dc3496 into main Mar 14, 2022
@julienduchesne julienduchesne deleted the julienduchesne/speed-improvement branch March 14, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzehring zzehring zzehring approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julienduchesne @zzehring