Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more functions #70

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

julienduchesne
Copy link
Member

Fetching attributes through builder pattern + mixins

Fetching attributes through builder pattern + mixins
@github-actions
Copy link

github-actions bot commented Sep 8, 2022

Benchstat (compared to main):

name                                                                    old time/op  new time/op   delta
Definition/test_goto_definition_for_var_myvar-2                         7.07µs ± 1%   6.50µs ± 6%   -8.07%  (p=0.016 n=4+5)
Definition/test_goto_definition_on_function_helper-2                    7.13µs ± 1%   6.75µs ± 7%     ~     (p=0.135 n=5+5)
Definition/test_goto_inner_definition-2                                 7.40µs ± 3%   6.75µs ± 4%   -8.78%  (p=0.008 n=5+5)
Definition/test_goto_super_index-2                                      7.43µs ± 2%   6.93µs ± 4%   -6.74%  (p=0.008 n=5+5)
Definition/test_goto_super_nested-2                                     7.30µs ± 2%   6.84µs ± 1%   -6.27%  (p=0.008 n=5+5)
Definition/test_goto_self_object_field_function-2                       7.83µs ± 0%   6.86µs ± 3%  -12.42%  (p=0.016 n=4+5)
Definition/test_goto_super_object_field_local_defined_obj_'foo'-2       7.98µs ± 4%   7.25µs ± 3%   -9.11%  (p=0.008 n=5+5)
Definition/test_goto_super_object_field_local_defined_obj_'g'-2         8.22µs ± 2%   7.38µs ± 3%  -10.21%  (p=0.008 n=5+5)
Definition/test_goto_local_var_from_other_local_var-2                   6.63µs ± 3%   5.88µs ± 3%  -11.30%  (p=0.008 n=5+5)
Definition/test_goto_local_obj_field_from_'self.attr'_from_other_obj-2  9.38µs ± 1%   9.53µs ±27%     ~     (p=0.690 n=5+5)
Definition/test_goto_local_object_'obj'_via_obj_index_'obj.foo'-2       7.46µs ± 1%   6.90µs ± 3%   -7.48%  (p=0.008 n=5+5)
Definition/test_goto_imported_file-2                                    19.3µs ± 3%   19.2µs ± 2%     ~     (p=1.000 n=5+5)
Definition/test_goto_imported_file_at_lhs_index-2                       7.82µs ± 1%   7.60µs ± 5%     ~     (p=0.151 n=5+5)
Definition/test_goto_imported_file_at_rhs_index-2                       7.95µs ± 2%   7.75µs ± 3%     ~     (p=0.151 n=5+5)
Definition/goto_import_index-2                                          7.11µs ± 2%   6.77µs ± 0%   -4.91%  (p=0.008 n=5+5)
Definition/goto_attribute_of_nested_import-2                            8.98µs ± 1%   8.64µs ± 3%   -3.83%  (p=0.008 n=5+5)
Definition/goto_dollar_attribute-2                                      7.78µs ± 0%   7.43µs ± 3%   -4.51%  (p=0.008 n=5+5)
Definition/goto_dollar_sub_attribute-2                                  8.68µs ± 1%   9.10µs ± 9%     ~     (p=0.151 n=5+5)
Definition/goto_dollar_doesn't_follow_to_imports-2                      7.82µs ± 1%   8.09µs ± 4%     ~     (p=0.095 n=5+5)
Definition/goto_attribute_of_nested_import_no_object_intermediary-2     8.02µs ± 2%   7.84µs ± 3%     ~     (p=0.310 n=5+5)
Definition/goto_self_in_import_in_binary-2                              47.8µs ± 2%   55.1µs ± 2%  +15.29%  (p=0.008 n=5+5)
Definition/goto_self_attribute_from_local-2                             7.52µs ± 2%   7.36µs ± 2%     ~     (p=0.135 n=5+5)
Definition/goto_function_parameter_from_inside_function-2               7.73µs ± 1%   7.51µs ± 2%   -2.79%  (p=0.008 n=5+5)
Definition/goto_local_func_param-2                                      8.23µs ± 2%   7.82µs ± 4%   -5.04%  (p=0.008 n=5+5)
Definition/goto_self_complex_scope_1-2                                  8.44µs ± 3%   7.65µs ± 6%   -9.28%  (p=0.008 n=5+5)
Definition/goto_self_complex_scope_2-2                                  9.34µs ± 2%   8.39µs ± 1%  -10.18%  (p=0.008 n=5+5)
Definition/goto_with_overrides:_clobber_string-2                         114µs ± 3%    123µs ± 1%   +7.35%  (p=0.008 n=5+5)
Definition/goto_with_overrides:_clobber_nested_string-2                  122µs ± 4%    125µs ± 3%     ~     (p=0.151 n=5+5)
Definition/goto_with_overrides:_clobber_map-2                            118µs ± 7%    122µs ± 4%     ~     (p=0.222 n=5+5)
Definition/goto_with_overrides:_map_(multiple_definitions)-2             119µs ± 6%    123µs ± 8%     ~     (p=0.151 n=5+5)
Definition/goto_with_overrides:_nested_map_(multiple_definitions)-2      133µs ± 2%    136µs ± 7%     ~     (p=0.310 n=5+5)
Definition/goto_with_overrides:_string_carried_from_super-2              117µs ± 1%    120µs ± 5%     ~     (p=0.222 n=5+5)
Definition/goto_with_overrides:_nested_string_carried_from_super-2       121µs ± 3%    127µs ± 3%   +4.91%  (p=0.016 n=5+5)
Definition/goto_with_overrides:_string_carried_from_local-2              117µs ± 4%    124µs ± 5%     ~     (p=0.056 n=5+5)
Definition/goto_with_overrides:_string_carried_from_import-2             119µs ± 5%    128µs ± 4%   +7.48%  (p=0.016 n=5+5)
Definition/goto_with_overrides:_string_carried_from_second_import-2      117µs ± 2%    125µs ± 2%   +6.57%  (p=0.008 n=5+5)
Definition/goto_deeply_nested_imported_attribute-2                      12.3µs ± 3%   11.8µs ± 2%   -4.16%  (p=0.016 n=5+5)
Definition/goto_deeply_nested_imported_attribute_through_self-2         59.7µs ± 7%   60.0µs ± 2%     ~     (p=0.421 n=5+5)
Definition/goto_computed_field_name_object_field-2                      8.42µs ± 3%   7.24µs ± 2%  -14.01%  (p=0.008 n=5+5)
Definition/goto_field_through_function-2                                8.28µs ± 4%   7.53µs ± 2%   -9.07%  (p=0.008 n=5+5)
Definition/goto_field_through_function-created_object-2                 92.0µs ± 3%  163.4µs ± 3%  +77.70%  (p=0.008 n=5+5)

@julienduchesne julienduchesne marked this pull request as ready for review September 8, 2022 02:33
@julienduchesne julienduchesne merged commit 076cbec into main Sep 8, 2022
@julienduchesne julienduchesne deleted the julienduchesne/support-more-functions branch September 8, 2022 02:33
julienduchesne added a commit that referenced this pull request Oct 12, 2022
Started in #63 and #70
I think this now covers all (or most) cases
Most of this PR is just tests, since the missing code was just missing a few cases in switch cases
julienduchesne added a commit that referenced this pull request Oct 12, 2022
Started in #63 and #70
I think this now covers all (or most) cases
Most of this PR is just tests, since the missing code was just missing a few cases in switch cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant