Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add critical pod priority to monitoring pods. #147

Merged
merged 2 commits into from
Jul 18, 2019
Merged

Add critical pod priority to monitoring pods. #147

merged 2 commits into from
Jul 18, 2019

Conversation

tomwilkie
Copy link
Contributor

Signed-off-by: Tom Wilkie tom.wilkie@gmail.com

@tomwilkie
Add critical pod priority to monitoring pods.
d334ab9 
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
@tomwilkie tomwilkie requested a review from beorn7 July 18, 2019 10:55
beorn7
beorn7 approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@beorn7 beorn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disclaimer: I have never worked with pod priorities.

ksonnet-util/kausal.libsonnet Show resolved Hide resolved
@tomwilkie
Review feedback
26c7652 
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
@tomwilkie tomwilkie merged commit b35bbf3 into master Jul 18, 2019
@tomwilkie tomwilkie deleted the pod-priority branch July 18, 2019 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beorn7 beorn7 beorn7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomwilkie @beorn7