Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-format files and switch to jsonnetfmt. #221

Merged
merged 1 commit into from Mar 18, 2020
Merged

Re-format files and switch to jsonnetfmt. #221

merged 1 commit into from Mar 18, 2020

Conversation

mplzik
Copy link
Contributor

@mplzik mplzik commented Mar 17, 2020 •
edited

Since v0.13.0, jsonnet fmt was separated into a jsonnetfmt library.
Also, reformat files, since some of them are triggering linter errors.

Fixes #224

@DanCech
Copy link
Contributor

DanCech commented Mar 17, 2020

You'll need to update the docker image circleci uses, which is built from the .circleci folder

@mplzik mplzik force-pushed the mplzik/fmt-and-switch-to-jsonnetfmt branch 3 times, most recently from ab49f59 to e50d00a Compare March 18, 2020 07:45
@mplzik
Copy link
Contributor Author

mplzik commented Mar 18, 2020

@DanCech this was done in #222 ; I waited for a green light there to continue working on this :-)

@mplzik
Re-format files and switch to jsonnetfmt.
6d8dd34 
This commit:
- switches to Grafana's jsonnet image with jsonnet v0.15.0,
- fixes lint script to fail if any of the linted files fails to check,
- reformats files so that linting succeeds.

This is a follow-up of #222
.

Signed-off-by: Milan Plzik <milan.plzik@grafana.com>
@mplzik mplzik force-pushed the mplzik/fmt-and-switch-to-jsonnetfmt branch from e50d00a to 6d8dd34 Compare March 18, 2020 07:59
@mplzik mplzik marked this pull request as ready for review March 18, 2020 08:05
@mplzik mplzik merged commit 03da9ea into master Mar 18, 2020
@mplzik mplzik deleted the mplzik/fmt-and-switch-to-jsonnetfmt branch March 18, 2020 08:08
@mplzik mplzik mentioned this pull request Oct 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Duologic Duologic Duologic approved these changes

@malcolmholmes malcolmholmes Awaiting requested review from malcolmholmes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linting in grafana/jsonnet-libs is broken
3 participants
@mplzik @DanCech @Duologic