Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[k6/experimental/browser] Add context.cookies and improve cookie TS definitions #14

Merged
merged 10 commits into from
Sep 26, 2023
Merged

[k6/experimental/browser] Add context.cookies and improve cookie TS definitions #14

merged 10 commits into from
Sep 26, 2023

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Sep 21, 2023 •
edited
Loading

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

@inancgumus inancgumus changed the base branch from add/1015-browser-page-on to master September 21, 2023 16:08
@CLAassistant
Copy link

CLAassistant commented Sep 21, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@inancgumus inancgumus marked this pull request as ready for review September 21, 2023 16:28
@inancgumus inancgumus self-assigned this Sep 21, 2023
@inancgumus
Merge two addCookies test into one for url
64a1b31 
Since this is about testing the type definitions, it's OK to put
properties into the same test.
@inancgumus
Add context.cookies tests
ffae279
@inancgumus inancgumus mentioned this pull request Sep 21, 2023
Closed
ankur22
ankur22 approved these changes Sep 22, 2023
View reviewed changes
Copy link

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for cleaning up and adding cookie related type defs 🚀 LGTM

types/k6/experimental/browser.d.ts Show resolved Hide resolved
types/k6/test/browser.ts Show resolved Hide resolved
@inancgumus inancgumus mentioned this pull request Sep 25, 2023
Merged
5 tasks
ka3de
ka3de approved these changes Sep 26, 2023
View reviewed changes
Copy link

@ka3de ka3de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@inancgumus inancgumus merged commit 8780d50 into master Sep 26, 2023
2 checks passed
@inancgumus inancgumus deleted the add/6-browsercontext-cookies branch September 26, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur22 ankur22 ankur22 approved these changes

@ka3de ka3de ka3de approved these changes

@mstoykov mstoykov Awaiting requested review from mstoykov mstoykov is a code owner

@codebien codebien Awaiting requested review from codebien codebien is a code owner

@oleiade oleiade Awaiting requested review from oleiade oleiade is a code owner

@olegbespalov olegbespalov Awaiting requested review from olegbespalov olegbespalov is a code owner

@ppcano ppcano Awaiting requested review from ppcano

@nicolevanderhoeven nicolevanderhoeven Awaiting requested review from nicolevanderhoeven nicolevanderhoeven is a code owner

Assignees

@inancgumus inancgumus

Labels
browser
Projects
None yet
Milestone
No milestone
4 participants
@inancgumus @CLAassistant @ankur22 @ka3de