Update Browser/BrowserContext API:s to return Promise

[allansson]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run pnpm test <package to test>.
• Provide a URL to documentation or source code which provides context for the suggested changes: Migrate Browser APIs to async xk6-browser#1294

[inancgumus]

Wow! Thanks a lot! I'm not sure how to review this, though (too many changes! 🙄). So, I trust you 👍

[ankur22]

So all the tests are ran concurrently now (at least the ones that work with promise), but within an async function which is awaited on.

Looks good 👍

[inancgumus]

@ankur22

all the tests are ran concurrently now (at least the ones that work with promise), but within an async function which is awaited on.

How did you get that?

[allansson]

Wow! Thanks a lot! I'm not sure how to review this, though (too many changes! 🙄). So, I trust you 👍

@inancgumus Oh, I see.

The reason for the amount of changes is that I wrapped all of the test-cases in an async function, because I had to do const page = await browser.newPage() and top-level await is not supported. Every line was changed because wrapping it in a function added indentation on every line.

Otherwise it's just updating the ExpectType to expect a Promise for the affected API:s.

I have run the tests and they all pass. 🙂

[inancgumus]

@allansson

Got it 👍 Makes sense now. I'd suggest doing each step in a separate commit with a description so that we can easily see and review the changes. For example:

• Adding the async updates only for Browser
• Adding the async updates only for BrowserContext
• Wrapping up things in an async function (with a description "why")

[allansson]

So all the tests are ran concurrently now (at least the ones that work with promise), but within an async function which is awaited on.

Looks good 👍

@ankur22 The function is actually never executed, it's just linted using the typescript type checker. So it doesn't matter if you await or not, unless you want to continue testing on some return value (e.g. await context.newPage()). 🙂