Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser: Use consistent naming and formatting #1596

Open
inancgumus opened this issue May 21, 2024 · 0 comments
Open

Browser: Use consistent naming and formatting #1596

inancgumus opened this issue May 21, 2024 · 0 comments
Labels
Area: browser The browser module

Comments

@inancgumus
Copy link
Member

inancgumus commented May 21, 2024

We want to clarify and maintain consistency in the name usage of the components within the documents. Currently, there are some inconsistencies throughout the documentation, which can be confusing for users.

Issue 1

For example, here:

"A single BrowserContext can have many pages."

We use BrowserContext in a code block and link to it. However, we neither capitalize nor link the page part. Should pages be Pages as a link, or an easier-to-read way like pages as a link?

  • Using pages as a link is easier to read in a sentence.
  • Using Pages as a link might be easier to understand the relationship between all the components.

Other examples:

Issue 2

Another issue is that sometimes we write component and method names in a code block as a link, sometimes without a link, and in others only as a link without a code block.

Example: https://grafana.com/docs/k6/latest/javascript-api/k6-experimental/browser/page/evaluatehandle/


Conclusion

  • While referring to the types, using [Cookies](link) is OK. But [cookies](link) is not.
  • In self-referential pages, we won't put concepts in a code block. For example, in the BrowserContext documentation, it doesn’t make sense to put BrowserContext in a code block. We can call it as just “browser context”.
  • Having type prefixes in a type’s documentation doesn’t make sense, and we'll remove the prefixes. For example, in Page, it doesn't make sense to say Page.click, it can be just click.
@inancgumus inancgumus added the Area: browser The browser module label May 21, 2024
@inancgumus inancgumus changed the title Browser: Use consistent naming Browser: Use consistent naming and formatting May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: browser The browser module
Projects
None yet
Development

No branches or pull requests

1 participant