Update k6-browser examples and move browser class to root as a module #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a version of the docs published here: https://mdr-ci.staging.k6.io/docs/refs/pull/1200/merge It will be deleted automatically in 30 days. |
inancgumus
force-pushed
the
update/1171-k6-browser-options
branch
from
a132835
to
3c2307b
Compare
mdcruz
reviewed
Jun 6, 2023
src/data/markdown/translated-guides/en/03 Using k6 browser/01 Overview.md
Outdated
Show resolved
Hide resolved
mdcruz
requested changes
Jun 7, 2023
There was a problem hiding this comment.
Thank you @inancgumus! The changes look great. I have made a few suggestions :)
Also, it probably makes sense to merge #1178 to this PR and check with @ankur22.
src/data/markdown/translated-guides/en/03 Using k6 browser/02 Running browser tests.md
Show resolved
Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/02 Running browser tests.md
Outdated
Show resolved
Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/02 Running browser tests.md
Show resolved
Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/02 Running browser tests.md
Show resolved
Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/02 Running browser tests.md
Outdated
Show resolved
Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/02 Running browser tests.md
Outdated
Show resolved
Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/03 Metrics.md
Outdated
Show resolved
Hide resolved
inancgumus
added a commit
that referenced
this pull request
Jun 7, 2023
inancgumus
added a commit
that referenced
this pull request
Jun 7, 2023
inancgumus
force-pushed
the
update/1171-k6-browser-options
branch
from
c910c40
to
b9eb766
Compare
mdcruz
reviewed
Jun 7, 2023
src/data/markdown/translated-guides/en/03 Using k6 browser/02 Running browser tests.md
Outdated
Show resolved
Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/02 Running browser tests.md
Outdated
Show resolved
Hide resolved
inancgumus
added a commit
that referenced
this pull request
Jun 7, 2023
inancgumus
added a commit
that referenced
this pull request
Jun 7, 2023
inancgumus
force-pushed
the
update/1171-k6-browser-options
branch
from
06cb77d
to
7517419
Compare
mdcruz
reviewed
Jun 8, 2023
src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser.md
Outdated
Show resolved
Hide resolved
src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/close.md
Outdated
Show resolved
Hide resolved
src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/isconnected.md
Outdated
Show resolved
Hide resolved
andrewslotin
approved these changes
Jun 8, 2023
src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser.md
Show resolved
Hide resolved
src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/close.md
Show resolved
Hide resolved
15 tasks
ka3de
reviewed
Jun 9, 2023
There was a problem hiding this comment.
Great work @inancgumus ! 👏 Thanks a lot for working on this!
Overall the changes in organization look good to me, I just mentioned a few considerations. Also, I see there are still examples that use the old init/close methods, but I guess it's because this is still in draft 👍
src/data/markdown/translated-guides/en/03 Using k6 browser/02 Running browser tests.md
Outdated
Show resolved
Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/02 Running browser tests.md
Outdated
Show resolved
Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/02 Running browser tests.md
Outdated
Show resolved
Hide resolved
src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser.md
Outdated
Show resolved
Hide resolved
src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser.md
Outdated
Show resolved
Hide resolved
src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/close.md
Show resolved
Hide resolved
src/data/markdown/docs/02 javascript api/07 k6-experimental/01 browser/on--event--.md
Outdated
Show resolved
Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/01 Overview.md
Show resolved
Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/02 Running browser tests.md
Outdated
Show resolved
Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/02 Running browser tests.md
Outdated
Show resolved
Hide resolved
inancgumus
added a commit
that referenced
this pull request
Jun 9, 2023
Resolves: #1200 (comment) Resolves: #1200 (comment) Resolves: #1200 (comment)
inancgumus
added a commit
that referenced
this pull request
Jun 16, 2023
inancgumus
added a commit
that referenced
this pull request
Jun 16, 2023
inancgumus
added a commit
that referenced
this pull request
Jun 16, 2023
Resolves: #1200 (comment) Resolves: #1200 (comment) Resolves: #1200 (comment)
inancgumus
added a commit
that referenced
this pull request
Jun 16, 2023
inancgumus
added a commit
that referenced
this pull request
Jun 16, 2023
ankur22
pushed a commit
that referenced
this pull request
Jun 29, 2023
ankur22
pushed a commit
that referenced
this pull request
Jun 29, 2023
ankur22
pushed a commit
that referenced
this pull request
Jun 29, 2023
Resolves: #1200 (comment) Resolves: #1200 (comment) Resolves: #1200 (comment)
ankur22
pushed a commit
that referenced
this pull request
Jun 29, 2023
ankur22
pushed a commit
that referenced
this pull request
Jun 29, 2023
inancgumus
added a commit
that referenced
this pull request
Jul 28, 2023
inancgumus
added a commit
that referenced
this pull request
Jul 28, 2023
inancgumus
added a commit
that referenced
this pull request
Jul 28, 2023
inancgumus
added a commit
that referenced
this pull request
Jul 28, 2023
inancgumus
added a commit
that referenced
this pull request
Aug 4, 2023
inancgumus
added a commit
that referenced
this pull request
Aug 4, 2023
inancgumus
added a commit
that referenced
this pull request
Aug 4, 2023
Resolves: #1200 (comment) Resolves: #1200 (comment) Resolves: #1200 (comment)
inancgumus
added a commit
that referenced
this pull request
Aug 4, 2023
inancgumus
added a commit
that referenced
this pull request
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates k6-browser examples to the new API (
browser.newPage) and movesBrowserclass as a module to the root page. 🚨 Check out the issue for the remaining tasks. I'll deal with them in another PR. Let's merge this to prevent merge conflicts.