Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grafana docs: fix links #1406

Merged
merged 10 commits into from
Nov 13, 2023
Merged

Grafana docs: fix links #1406

merged 10 commits into from
Nov 13, 2023

Conversation

heitortsergent
Copy link
Collaborator

@heitortsergent heitortsergent commented Nov 9, 2023

Closes #1396.

Fix any remaining links that still have the (/format (instead of using the full Grafana URL).

@heitortsergent heitortsergent marked this pull request as ready for review November 10, 2023 01:02
@heitortsergent
Copy link
Collaborator Author

@jdbaldry I added you as a reviewer but this PR is obviously too big. 😅 But if you wanted to take a quick look, I think I got all the remaining links that we missed during the migration... It would be great if we could run some sort of link crawler to see if there's anything that might have slipped through or might just have the wrong URL.

@jdbaldry
Copy link
Member

I agree that an ad hoc link crawler would be great.
I don't have anything to hand right now but have opened https://github.com/grafana/technical-documentation/issues/845 to track it

Copy link
Member

@jdbaldry jdbaldry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a scan this seems to fix a significant number of links without any negative side effects.

Thank you so much.

I can request another site crawl from Anne (maybe just even for this section of docs) to see what links are still left after this is merged.

@heitortsergent heitortsergent merged commit 59c76e2 into main Nov 13, 2023
6 checks passed
@heitortsergent heitortsergent deleted the grafana-fix-links branch November 13, 2023 20:30
@heitortsergent
Copy link
Collaborator Author

Ah yes, a site crawl would be great! And thanks for reviewing it 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix broken links
2 participants