Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate v0.48.0 release browser doc updates #1413

Merged
merged 4 commits into from Nov 21, 2023

Conversation

ankur22
Copy link
Contributor

@ankur22 ankur22 commented Nov 14, 2023

What

Migrating 3 commits from an old branch to the new way of working with doc updates.

Why

So that we don't lose the release changes coming up for v0.48.0.

@ankur22 ankur22 force-pushed the migrate/release-browser-changes branch from 27618bb to 46d6448 Compare November 14, 2023 13:35
@ankur22 ankur22 changed the title Migrate v0.48.0 release browser changes Migrate v0.48.0 release browser doc updates Nov 14, 2023
Copy link
Contributor

@ka3de ka3de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for taking the time to migrate these commits 🙌
For what I see, the format from previous version is maintained, so the only thing that I think we missed is some URLs to be updated to the new "version".

Copy link
Contributor

@ka3de ka3de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@inancgumus inancgumus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ankur22 and others added 4 commits November 21, 2023 13:42
Co-authored-by: ka3de <daniel.jimenez@grafana.com>
- It removes the WIP tags and reformats the table markdown on the main
browserContext page.
- It removes the WIP notice, updates the description, updates the
return value, and adds an example in the waitForEvent page.
Co-authored-by: ka3de <daniel.jimenez@grafana.com>
@ankur22 ankur22 force-pushed the migrate/release-browser-changes branch from 048cbe8 to fce579f Compare November 21, 2023 13:42
@ankur22 ankur22 merged commit cf59f01 into main Nov 21, 2023
2 checks passed
@ankur22 ankur22 deleted the migrate/release-browser-changes branch November 21, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants