Add page.throttleCPU and page.throttleNetwork docs #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ka3de
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Overall LGTM. Just a consideration, but I think @heitortsergent will provide better feedback on the organization. As far as the content goes it is correct to me.
docs/sources/next/javascript-api/k6-experimental/browser/page/throttlenetwork.md
Show resolved
Hide resolved
ankur22
force-pushed
the
add/throttling
branch
from
11932d2
to
9d2ab8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This adds the documentation for
page.throttleCPUandpage.throttleNetworkwhich are both new APIs which are part of the browser module.Why
To inform users how to work with these new APIs.