Update version banner #1431
Merged
Update version banner #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ppcano I think I was able to figure out the version banner, let me know how it looks! 🙏 |
ppcano
reviewed
Nov 29, 2023
| @@ -1,6 +1,6 @@ | |||
| .container { | |||
| margin-bottom: 20px; | |||
| margin-top: 115px; | |||
| margin-top: 165px; | |||
There was a problem hiding this comment.
On my screen, the margin seems too large.
There was a problem hiding this comment.
Ah good catch, thanks @ppcano! I just updated the PR, I think it's fixed now so the higher margin-top only applies to the JS API section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update the version banner for the JavaScript API section to display on latest version, and update link to point to Grafana docs.
Checklist
Please fill in this template:
npm startcommand locally and verified that the changes look good.