Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add browser M1/M2 Macs Docker steps #1437

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Add browser M1/M2 Macs Docker steps #1437

merged 3 commits into from
Dec 6, 2023

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Dec 4, 2023 •
edited
Loading

What?

  • Running the browser with Docker on M1/M2 Macs requires additional steps.
  • This PR adds the steps in the Running browser tests document as a 3rd optional step.

Checklist

Please fill in this template:

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the make docs command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/next folder of the documentation.

Related PR(s)/Issue(s)

Closes: #1317

@inancgumus inancgumus marked this pull request as ready for review December 4, 2023 09:17
@inancgumus inancgumus self-assigned this Dec 4, 2023
@inancgumus inancgumus added the Area: browser The browser module label Dec 4, 2023
mdcruz
mdcruz reviewed Dec 4, 2023
View reviewed changes
Copy link
Contributor

@mdcruz mdcruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few minor comments :)

docs/sources/next/using-k6-browser/running-browser-tests.md Outdated Show resolved Hide resolved
docs/sources/next/using-k6-browser/running-browser-tests.md Outdated Show resolved Hide resolved
ankur22
ankur22 approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

heitortsergent
heitortsergent approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple small comments but LGTM. :shipit:

docs/sources/next/using-k6-browser/running-browser-tests.md Outdated Show resolved Hide resolved
docs/sources/next/using-k6-browser/running-browser-tests.md Show resolved Hide resolved
inancgumus and others added 2 commits December 6, 2023 13:00
@inancgumus
Add browser M1/M2 Macs Docker steps
6606051
@inancgumus @mdcruz
Fix typos in M1/M2 mac steps
04387eb 
Co-authored-by: Marie Cruz <mdcruz@users.noreply.github.com>
@inancgumus @heitortsergent
Update mac docket steps bold nesting
3ee2830 
Co-authored-by: Heitor Tashiro Sergent <heitortsergent@gmail.com>
@inancgumus inancgumus merged commit bb58293 into main Dec 6, 2023
5 checks passed
@inancgumus inancgumus deleted the add/browser-m1m2-docker-steps branch December 6, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heitortsergent heitortsergent heitortsergent approved these changes

@ankur22 ankur22 ankur22 approved these changes

@ka3de ka3de Awaiting requested review from ka3de

@mdcruz mdcruz Awaiting requested review from mdcruz

Assignees

@inancgumus inancgumus

Labels
Area: browser The browser module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explain k6-browser Docker steps for Mac M1/M2 users
4 participants
@inancgumus @heitortsergent @ankur22 @mdcruz