Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix browser imports in examples #1449

Merged
merged 3 commits into from Dec 7, 2023
Merged

Fix browser imports in examples #1449

merged 3 commits into from Dec 7, 2023

Conversation

ankur22
Copy link
Contributor

@ankur22 ankur22 commented Dec 7, 2023

What?

This fixes a few browser imports in the browser module examples from:

import { chromium } from 'k6/experimental/browser';

to:

import { browser } from 'k6/experimental/browser';

Checklist

Please fill in this template:

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the make docs command locally and verified that the changes look good.

Select one of these and delete the others:

If updating the documentation for the most recent release of k6:

  • I have made my changes in the docs/sources/next folder of the documentation.
  • I have reflected my changes in the docs/sources/v{most_recent_release} folder of the documentation.
  • I have reflected my changes in the relevant (e.g. when correcting a documentation error) folders of the previous k6 versions of the documentation.

If updating the documentation for the next release of k6:

  • I have made my changes in the docs/sources/next folder of the documentation.

Related PR(s)/Issue(s)

Ensure that that the examples import browser and not chromium for the
browser module examples throughout the documentation.
Copy link
Member

@inancgumus inancgumus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@ankur22 ankur22 merged commit 8366244 into main Dec 7, 2023
6 checks passed
@ankur22 ankur22 deleted the fix/imports-browser branch December 7, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants