Update browser module dblclick docs #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankur22
commented
Dec 20, 2023
| | <a href="https://playwright.dev/docs/api/class-frame#frame-child-frames" target="_blank" >frame.childFrames()</a> | - | | ||
| | <a href="https://playwright.dev/docs/api/class-frame#frame-click" target="_blank" >frame.click(selector[, options])</a> | - | | ||
| | <a href="https://playwright.dev/docs/api/class-frame#frame-content" target="_blank" >frame.content()</a> | - | | ||
| | [frame.dblclick(selector[, options])](https://grafana.com/docs/k6/<K6_VERSION>/javascript-api/k6-experimental/browser/frame/dblclick) | Double click on an element matching the provided `selector`. | |
There was a problem hiding this comment.
This is the change in this file.
ankur22
commented
Dec 20, 2023
| @@ -7,28 +7,27 @@ excerpt: 'Browser module: locator.dblclick method' | |||
|
|
|||
| {{% admonition type="caution" %}} | |||
|
|
|||
| This feature has known issues. For details, refer to | |||
| [#469](https://github.com/grafana/xk6-browser/issues/469) and [#471](https://github.com/grafana/xk6-browser/issues/471). | |||
| This feature has known issues. For details, refer to [#471](https://github.com/grafana/xk6-browser/issues/471). | |||
There was a problem hiding this comment.
The main change is here.
inancgumus
reviewed
Dec 20, 2023
docs/sources/next/javascript-api/k6-experimental/browser/element-handle/_index.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/browser/element-handle/dblclick.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/browser/element-handle/dblclick.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/browser/element-handle/dblclick.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/browser/element-handle/dblclick.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/browser/element-handle/dblclick.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/browser/element-handle/dblclick.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/browser/frame/dblclick.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/browser/frame/dblclick.md
Outdated
Show resolved
Hide resolved
docs/sources/next/javascript-api/k6-experimental/browser/frame/dblclick.md
Outdated
Show resolved
Hide resolved
ankur22
force-pushed
the
update/browser-dblclick
branch
from
3c703f3
to
4dfaddd
Compare
Co-authored-by: İnanç Gümüş <inanc.gumus@grafana.com>
ankur22
force-pushed
the
update/browser-dblclick
branch
from
4dfaddd
to
0abcf69
Compare
inancgumus
approved these changes
Dec 21, 2023
heitortsergent
approved these changes
Dec 21, 2023
docs/sources/next/javascript-api/k6-experimental/browser/elementhandle/dblclick.md
Outdated
Show resolved
Hide resolved
| | options | object | `null` | | | ||
| | options.button | string | `left` | The mouse button (`left`, `middle` or `right`) to use during the action. | | ||
| | options.delay | number | `0` | Milliseconds to wait between `mousedown` and `mouseup`. | | ||
| | options.force | boolean | `false` | Bypasses the actionability checks (i.e., `visible`, `stable`, `enabled`) if set to `true`. |
There was a problem hiding this comment.
Same as previous comment.
Co-authored-by: ka3de <daniel.jimenez@grafana.com>
…nthandle/dblclick.md Co-authored-by: Heitor Tashiro Sergent <heitortsergent@gmail.com>
ankur22
force-pushed
the
update/browser-dblclick
branch
from
4fee11c
to
ef1cc2b
Compare
ankur22
added a commit
that referenced
this pull request
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the
dblclickAPI forelementHandle,frameandlocator.Checklist
Please fill in this template:
make docscommand locally and verified that the changes look good.If updating the documentation for the next release of k6:
docs/sources/nextfolder of the documentation.Related PR(s)/Issue(s)
Related to issue: grafana/xk6-browser#469