Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update built-in metrics description #1459

Merged
merged 7 commits into from
Jan 11, 2024

Conversation

heitortsergent
Copy link
Collaborator

What?

Update some of the descriptions for the Web Vital Metrics, and reorder the tables on that page.

Checklist

Please fill in this template:

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the make docs command locally and verified that the changes look good.

If updating the documentation for the most recent release of k6:

  • I have made my changes in the docs/sources/next folder of the documentation.
  • I have reflected my changes in the docs/sources/v{most_recent_release} folder of the documentation.
  • I have reflected my changes in the relevant (e.g. when correcting a documentation error) folders of the previous k6 versions of the documentation.

Copy link
Collaborator

@ppcano ppcano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two changes have been requested.

Additionally, there are conflicting files to be resolved before this can be merged.

I am unsure whether it is necessary to update old API versions.

@heitortsergent heitortsergent merged commit 363d7fb into main Jan 11, 2024
6 checks passed
@heitortsergent heitortsergent deleted the chore/update-metrics-description branch January 11, 2024 18:23
@heitortsergent
Copy link
Collaborator Author

Thanks for the review @ppcano 🙇 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants