Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary '$' to allow copying and pasting #146

Closed
wants to merge 1 commit into from

Conversation

joshuaj004
Copy link

When you copy the command, it copies the '$' as well which causes an error when you paste it into your terminal. If you look at the 'Adding more VUs' section, these commands omit the '$' so I believe this is the correct behavior.

Btw I love using k6!

@joshuaj004
Copy link
Author

I didn't modify anything relating to the deployment process, so I think you should be able to re-run it and have it work. I'm not sure how to do this, thoughts?

@ppcano
Copy link
Collaborator

ppcano commented Nov 9, 2020

@joshuaj004 Thank you for pointing out and the PR.

@simskij This is a common issue in the Docs.

Screen Shot 2020-11-09 at 4 15 16 PM

If we want to prepend the symbol - which I am not sure - we should do it in CSS and skip it when copying.

@bolotskydev
Copy link
Collaborator

@ppcano FYI, I can implement that fairly easy, but some of our bash code blocks contain powershell code and I don't think I'd be able to distinguish it programmatically with current setup. That means, some powershell code will be prepended with $ as well, which could be quite confusing.

Solution in current setup: replace bash with plain in powershell code blocks.
Solution with refactoring: well, add powershell support.

@ppcano
Copy link
Collaborator

ppcano commented Nov 16, 2020

Thank @bolotskydev for informing us.

@simskij was discussing this issue internally and will inform the decision.

@simskij
Copy link
Contributor

simskij commented Nov 19, 2020

Hi Josh,

Thank you for the suggestion! We've decided to keep the dollar signs in the scripts for now. However, we would like to proceed with @bolotskydev's idea about omitting them when copying. I'm creating a separate issue for that.

Closing this PR without merging. With that said, I'd like to thank you again for the excellent contribution. It definitely got us thinking through the UX.

Best,
Simme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants