Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for locator.clear #1468

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Add docs for locator.clear #1468

merged 2 commits into from
Jan 11, 2024

Conversation

ankur22
Copy link
Contributor

@ankur22 ankur22 commented Jan 10, 2024

What?

This PR adds documentation for the new locator.clear API in the browser module.

Checklist

Please fill in this template:

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the make docs command locally and verified that the changes look good.

If updating the documentation for the next release of k6:

  • I have made my changes in the docs/sources/next folder of the documentation.

Related PR(s)/Issue(s)

grafana/xk6-browser#1114

@ankur22 ankur22 marked this pull request as draft January 10, 2024 10:08
@ankur22 ankur22 marked this pull request as ready for review January 10, 2024 14:29
Copy link
Member

@inancgumus inancgumus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 w/one suggestion.

The existing example might have confused readers since an empty input
element was being cleared. The change now brings in an example where
an input field is filled in and then cleared.
@ankur22 ankur22 merged commit 5fd04e5 into main Jan 11, 2024
6 checks passed
@ankur22 ankur22 deleted the add/locator-clear branch January 11, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants