Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the web dashboard feature #1484

Merged
merged 4 commits into from Jan 25, 2024
Merged

Document the web dashboard feature #1484

merged 4 commits into from Jan 25, 2024

Conversation

oleiade
Copy link
Member

@oleiade oleiade commented Jan 18, 2024

What?

This PR aims to document the web dashboard feature that lands in v0.49.0 of k6.

I've been struggling somewhat to put this together, and I'd really like as much input, suggestions and feedback as possible as to how to structure this, the amount of detail we want to provide, as well as where it should live.

@szkiba I would especially love your input on this too 馃憤

Checklist

Please fill in this template:

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the make docs command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/next folder of the documentation.

@oleiade oleiade self-assigned this Jan 18, 2024
@oleiade oleiade requested a review from szkiba January 18, 2024 16:25
Copy link
Contributor

@szkiba szkiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

K6_WEB_DASHBOARD_REPORT_FILENAME should be change to K6_WEB_DASHBOARD_EXPORT

docs/sources/next/results-output/web-dashboard/_index.md Outdated Show resolved Hide resolved
The HTML test report can be accessed from the dashboard's menu, by clicking on the "Report" button.

![HTML test report generation button](/media/docs/k6-oss/web-dashboard-report-button.png)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps a sentence could be written about how the report can be automatically saved using the K6_WEB_DASHBOARD_EXPORT environment variable, without starting a browser.

Copy link
Collaborator

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oleiade I think this is really good, thanks for writing this up!

I made some suggestions for changing the order of the sections and the headings, and some suggestions related to our Grafana style guide. :)

I think the location of the page makes sense, we could also add a mention of it to the "Results output" page under the Get started section. Maybe as a new heading right above the "Time series and external outputs" section: https://grafana.com/docs/k6/latest/get-started/results-output/#time-series-and-external-outputs

Two questions I have:

  • Would it make sense to have some sort of admonition at the top and point people to the xk6-dashboard repository if people want to give feedback on the dashboard?

  • I saw this section on the xk6-dashboard README, and I'm wondering if we should include it as well?

    "The k6 process waits to exit as long as there is at least one open browser window for the dashboard extension. In this way, the report can be downloaded, for example, even after the test has been completed.

    In certain environments, it is not allowed that the k6 process does not exit after the test run (eg CI/CD pipeline). In this case, it is advisable to disable the HTTP port (with the -1 value of port parameter)."

docs/sources/next/results-output/web-dashboard/_index.md Outdated Show resolved Hide resolved
docs/sources/next/results-output/web-dashboard/_index.md Outdated Show resolved Hide resolved
docs/sources/next/results-output/web-dashboard/_index.md Outdated Show resolved Hide resolved
docs/sources/next/results-output/web-dashboard/_index.md Outdated Show resolved Hide resolved
docs/sources/next/results-output/web-dashboard/_index.md Outdated Show resolved Hide resolved

![HTML test report generation button](/media/docs/k6-oss/web-dashboard-report-button.png)

## How to use
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should move this section above the "HTML test reports" one, so it goes: Introduction, How to use, HTML reports, Dashboard options.

docs/sources/next/results-output/web-dashboard/_index.md Outdated Show resolved Hide resolved
docs/sources/next/results-output/web-dashboard/_index.md Outdated Show resolved Hide resolved
docs/sources/next/results-output/web-dashboard/_index.md Outdated Show resolved Hide resolved
docs/sources/next/results-output/web-dashboard/_index.md Outdated Show resolved Hide resolved
Co-authored-by: Heitor Tashiro Sergent <heitortsergent@gmail.com>
Copy link
Collaborator

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oleiade thanks for making the updates!

I think we can get this merged if you want and make improvements later on. :)

I'd still like to move the "How to use" section up, and I left a suggestion for how we can mention the K6_WEB_DASHBOARD_EXPORT variable.

@szkiba I don't know if you saw my comment, but are the warnings we have on the xk6-dashboard Usage section still applicable here? If they are, I think it would make sense to mention it in the docs as well.

oleiade and others added 2 commits January 25, 2024 09:19
@oleiade oleiade merged commit 7e0d855 into main Jan 25, 2024
6 checks passed
@oleiade oleiade deleted the feature/web-dashboard branch January 25, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants