Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Modules and JavaScript Compatibility Mode docs #1489

Merged
merged 21 commits into from Feb 14, 2024

Conversation

ppcano
Copy link
Collaborator

@ppcano ppcano commented Jan 26, 2024

What?

Checklist

Please fill in this template:

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the make docs command locally and verified that the changes look good.

@ppcano ppcano marked this pull request as ready for review January 26, 2024 15:13
@ppcano ppcano changed the title OSS: Update module related docs WIP - Update Modules and JavaScript Compatibility Mode docs Jan 26, 2024
@ppcano ppcano changed the title WIP - Update Modules and JavaScript Compatibility Mode docs Update Modules and JavaScript Compatibility Mode docs Jan 26, 2024
@ppcano ppcano requested a review from mstoykov January 26, 2024 16:10
@ppcano
Copy link
Collaborator Author

ppcano commented Jan 26, 2024

@mstoykov please, could you provide a technical review and share any suggestions?

Copy link
Collaborator

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the next files, I just left a few comments with some small edits to follow our style guide. It would be great to still get a technical review before we merge.

docs/sources/next/using-k6/modules.md Outdated Show resolved Hide resolved
docs/sources/next/using-k6/modules.md Outdated Show resolved Hide resolved
docs/sources/next/using-k6/modules.md Outdated Show resolved Hide resolved
docs/sources/next/using-k6/modules.md Outdated Show resolved Hide resolved
docs/sources/next/using-k6/modules.md Outdated Show resolved Hide resolved
@ppcano
Copy link
Collaborator Author

ppcano commented Feb 7, 2024

Suggestions from @heitortsergent are now included and ported to previous versions. Additionally, all the changes were ported to v0.49.

It would be great to still get a technical review before we merge.

cc @mstoykov

Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general

Left some comments around stuff that I think might be better

ppcano and others added 16 commits February 14, 2024 08:45
Co-authored-by: Heitor Tashiro Sergent <heitortsergent@gmail.com>
Co-authored-by: Heitor Tashiro Sergent <heitortsergent@gmail.com>
Co-authored-by: Heitor Tashiro Sergent <heitortsergent@gmail.com>
Co-authored-by: Heitor Tashiro Sergent <heitortsergent@gmail.com>
Co-authored-by: Heitor Tashiro Sergent <heitortsergent@gmail.com>
Co-authored-by: Heitor Tashiro Sergent <heitortsergent@gmail.com>
Co-authored-by: Heitor Tashiro Sergent <heitortsergent@gmail.com>
Co-authored-by: Heitor Tashiro Sergent <heitortsergent@gmail.com>
Co-authored-by: Heitor Tashiro Sergent <heitortsergent@gmail.com>
Co-authored-by: Heitor Tashiro Sergent <heitortsergent@gmail.com>
Co-authored-by: Heitor Tashiro Sergent <heitortsergent@gmail.com>
Co-authored-by: Heitor Tashiro Sergent <heitortsergent@gmail.com>
docs/sources/next/using-k6/modules.md Outdated Show resolved Hide resolved
docs/sources/next/using-k6/modules.md Outdated Show resolved Hide resolved
ppcano and others added 2 commits February 14, 2024 13:02
Co-authored-by: Olha Yevtushenko <yorugac@users.noreply.github.com>
@ppcano
Copy link
Collaborator Author

ppcano commented Feb 14, 2024

@heitortsergent, I have addressed all the requests, and seems ready for the merge.

@heitortsergent heitortsergent merged commit c6a77ca into main Feb 14, 2024
1 check passed
@heitortsergent heitortsergent deleted the pepe/compatibility-update branch February 14, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants