Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misleading gRPC connection params defaults #1492

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Jan 26, 2024

What?

This change fixes the misleading "Defaults" for the grpc's connection params.

Checklist

Please fill in this template:

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the make docs command locally and verified that the changes look good.

Select one of these and delete the others:

If updating the documentation for the most recent release of k6:

  • I have made my changes in the docs/sources/next folder of the documentation.
  • I have reflected my changes in the docs/sources/v{most_recent_release} folder of the documentation.
  • I have reflected my changes in the relevant (e.g. when correcting a documentation error) folders of the previous k6 versions of the documentation.

If updating the documentation for the next release of k6:

  • I have made my changes in the docs/sources/next folder of the documentation.

Related PR(s)/Issue(s)

Closes #1434

@olegbespalov olegbespalov requested review from a team, mstoykov and codebien and removed request for a team January 26, 2024 11:51
@olegbespalov olegbespalov changed the title Fix misleading gRPC connection params. Fix misleading gRPC connection params defaults Jan 26, 2024
@olegbespalov olegbespalov added the Area: OSS Content Improvements or additions to community/oss documentation label Jan 26, 2024
Copy link
Contributor

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I agree with you we should move to a more human-friendly text.

@olegbespalov olegbespalov merged commit 59142fa into main Feb 2, 2024
6 checks passed
@olegbespalov olegbespalov deleted the fix/grpc-params branch February 2, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: OSS Content Improvements or additions to community/oss documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gRPC connect params documentation misleading
3 participants