Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.51.x documentation #1578

Merged
merged 1 commit into from
May 13, 2024
Merged

Release v0.51.x documentation #1578

merged 1 commit into from
May 13, 2024

Conversation

codebien
Copy link
Contributor

What?

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/next folder of the documentation.
  • I have reflected my changes in the docs/sources/v{most_recent_release} folder of the documentation.
  • I have reflected my changes in the relevant folders of the two previous k6 versions of the documentation (if still applicable to previous versions).
  • I have made my changes in the docs/sources/next folder of the documentation.

Related PR(s)/Issue(s)

@codebien codebien self-assigned this Apr 30, 2024
@codebien
Copy link
Contributor Author

Hey @heitortsergent, apparently the next folder has a bunch of errors.

cd grafana/k6-docs
cp -r ./docs/sources/next ./docs/sources/v0.51.x
git add .
git commit -m "bla bla commit message"

It returns errors and makes the commit command fail. To force the commit I had to add a condition into eslintignore file to exclude entirely the new v0.51.x folder.

Is it a known issue? What is the plan?

@inancgumus
Copy link
Member

@codebien We've improved the Tap docs with an additional PR: #1581. FYI. Let me know if I need to do something about it.

@codebien codebien requested review from a team, olegbespalov and joanlopez and removed request for a team May 13, 2024 10:56
@codebien
Copy link
Contributor Author

codebien commented May 13, 2024

FYI, I intend to force the CI to merge. @heitortsergent and the docs team will work on the CI fixes during the next cycle.

@codebien codebien merged commit d867731 into main May 13, 2024
3 of 5 checks passed
@codebien codebien deleted the release-v0.51.0 branch May 13, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants