Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update terser dependency vulnerability #17

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

mcnamaram
Copy link
Contributor

  • also fix unit tests with localstack

- also fix unit tests with localstack
@mstoykov
Copy link
Contributor

Thanks for this PR 🙇

It looks all alright but I don't get why you need to rename the hostname, although it also works. Which is also confusing and I guess this is just me not gettign something that docker does ? 🤔

This was referenced Sep 14, 2022
@mike-mcnamara
Copy link

it was confusing to me too. it is actually a localstack path-style issue where AWS is deprecating path-style and to use virtual hosting in localstack we can't run "localhost:4566" without updating /etc/hosts file. i did some digging and a much shorter path than what I went through is:
localstack/localstack#1792
https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html
and https://docs.localstack.cloud/aws/s3/ at the bottom.
In my testing, i discovered it handles it for all the localstack services so just changing hostname was easier than making some hack to support s3 alone.

@mstoykov mstoykov merged commit af29d69 into grafana:main Sep 16, 2022
@mike-mcnamara mike-mcnamara deleted the wip/update-dependency branch September 16, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants