Fix unsigned headers error #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Can we create a teat that covers this error? All the tests pass, maybe because we are not testing against aws? |
Merged
oleiade
approved these changes
Jan 3, 2023
There was a problem hiding this comment.
Great changes. I believe this shall fix #28, indeed 👏🏻
Regarding testing this change, I believe we need to add a step to verify that the the host header has indeed been added by the signing process in this one: https://github.com/grafana/k6-jslib-aws/blob/main/tests/internal/new_signature.js#LL80C4-L91C15
PS: also while we're at it, we could rename the tests/internal/new_signature.js file to signature.js. The new_signature naming is a leftover of the signature code's rewrite.
…e a host header once signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to fix #28