Kms #6
Kms #6
Conversation
|
|
There was a problem hiding this comment.
Thank you so much for your contribution @hagabor 🎉 🙇🏻 Much appreciated!
This looks excellent indeed. I've left a bunch of suggestions that are mainly targeted towards improving type-safety, naming, documentation and hiding AWS internal naming conventions. Please let me know if you see potential further refinements, and incorporate them 🙇🏻
I will be testing this against our AWS setup and get back to you as soon as I have confirmed for myself that it works as expected.
Note that I'll be out of office for the upcoming week, and might be slower to repond in that time period 😉
PS: Once we're good to go, I'll amend your PR with a regeneration of .map file as some type names will have changed 👍🏻
Cheers!
|
PR Checklist:
|
|
I've tested the KMS feature you introduced @hagabor and everything seems to work as expected 🎉 Great job 🤝 Please go ahead and integrate the suggested changes, and we should be good to merge this in preparation for a Cheers! |
|
Dear Théo, Sorry to responded with such delay. I'm going to integrate the suggested changes. brgds, |
Co-authored-by: Théo Crevon <oleiade@users.noreply.github.com>
Co-authored-by: Théo Crevon <oleiade@users.noreply.github.com>
Co-authored-by: Théo Crevon <oleiade@users.noreply.github.com>
Co-authored-by: Théo Crevon <oleiade@users.noreply.github.com>
Co-authored-by: Théo Crevon <oleiade@users.noreply.github.com>
Co-authored-by: Théo Crevon <oleiade@users.noreply.github.com>
Co-authored-by: Théo Crevon <oleiade@users.noreply.github.com>
|
Dear Théo, I've added some changes. One place I've left comment from the initial SecretsManager service (what I've used as starting point). Also changed export, and import symbols. Now seems working. Please review if I can ask you. Thanks! Brgds, |
|
Hey @hagabor Thanks a lot for this, much appreciated 🙇🏻 |
Added KMS Service with GenerateDataKey function only (with parameters only for KeyId and NumberOfBytes).