Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address empty list objects calls #9

Merged
merged 2 commits into from
Aug 30, 2022

Conversation

oleiade
Copy link
Member

@oleiade oleiade commented Aug 30, 2022

This PR addresses #8, and ensures that S3Client.listObjects calls go through successfully.

Because previously the optional prefix parameter would hold undefined instead of an empty string when not set, it would end up causing the list object to call to request objects with the undefined prefix, which, of course, would return an empty Array.

closes #8

@oleiade oleiade added the bug Something isn't working label Aug 30, 2022
@oleiade oleiade added this to the 0.5.0 milestone Aug 30, 2022
@oleiade oleiade self-assigned this Aug 30, 2022
@oleiade oleiade merged commit 3e612f0 into main Aug 30, 2022
@oleiade oleiade deleted the fix/8_address_empty_list_objects_calls branch August 30, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3Client.listObjects always return an empty array
1 participant