Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assigning runner's security context to k6 initializer #210

Closed
mohamediag opened this issue Mar 28, 2023 · 6 comments
Closed

Assigning runner's security context to k6 initializer #210

mohamediag opened this issue Mar 28, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@mohamediag
Copy link
Contributor

mohamediag commented Mar 28, 2023

Feature Description

We would need to define securityContext on all pods created by K6 operator as per security requirement , but currently the initializer doesn't provide an option to do it.

Suggested Solution (optional)

No response

Already existing or connected issues / PRs (optional)

No response

@mohamediag mohamediag added the enhancement New feature or request label Mar 28, 2023
@yorugac
Copy link
Collaborator

yorugac commented Mar 28, 2023

Hi @mohamediag, thanks for opening the issue! One way to resolve this is in the PR #175 - with it, you should be able to explicitly specify initializer spec separately from the runner.

But it might also be good to consider adding security context assigned in initializer definition by default: similarly to how its done in the runner definition.

@mohamediag
Copy link
Contributor Author

Hi @yorugac , seems the first PR is not being looked for a while, therefore the second option is fine for me as it seems quick to implement.

Shall a raise a PR for it if the repo is open for external contributor or can someone do it?

@yorugac
Copy link
Collaborator

yorugac commented Mar 30, 2023

Please feel free to work on the PR with assigning runner's security context to initializer @mohamediag 🙂 It doesn't contradict PR #175 but complements it so it'd be good to have it anyway.

@yorugac yorugac changed the title support adding a security context the k6 initializer Assigning a runner's security context to the k6 initializer Mar 30, 2023
@yorugac yorugac changed the title Assigning a runner's security context to the k6 initializer Assigning runner's security context to k6 initializer Mar 30, 2023
@mohamediag
Copy link
Contributor Author

PR opened : #215

@mohamediag
Copy link
Contributor Author

Hi @yorugac any idea when the PR can be reviewed and merged?

@yorugac
Copy link
Collaborator

yorugac commented Apr 24, 2023

Closed by #215

@yorugac yorugac closed this as completed Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants