Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assigning securityContext in k6 initializer #215

Conversation

mohamediag
Copy link
Contributor

for #210

@CLAassistant
Copy link

CLAassistant commented Apr 18, 2023

CLA assistant check
All committers have signed the CLA.

@yorugac yorugac changed the title assigning-runner-security-context-to-k6-initializer Assigning runner's securityContext to k6-initializer Apr 19, 2023
@yorugac
Copy link
Collaborator

yorugac commented Apr 21, 2023

Hi @mohamediag! Thank you for working on this one. We had a bit of funny timing as PR #175 was simultaneously updated and merged in 😅 Could you please rebase your branch on main and adjust your changes for the new names of vars? Thanks!

@mohamediag mohamediag force-pushed the assigning-runner-security-context-to-k6-initializer branch from 13e339e to 53a3673 Compare April 22, 2023 10:56
@mohamediag
Copy link
Contributor Author

Hi @yorugac , ha great that the other one has been merged - thanks
Rebase done and PR amended

@yorugac yorugac changed the title Assigning runner's securityContext to k6-initializer Assigning securityContext in k6 initializer Apr 24, 2023
Copy link
Collaborator

@yorugac yorugac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you; merging in.

@yorugac yorugac merged commit f3ca093 into grafana:main Apr 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants