Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image names should be more specific #221

Closed
yorugac opened this issue Apr 28, 2023 · 0 comments · Fixed by #247
Closed

Image names should be more specific #221

yorugac opened this issue Apr 28, 2023 · 0 comments · Fixed by #247
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@yorugac
Copy link
Collaborator

yorugac commented Apr 28, 2023

Feature Description

We're building all images for k6-operator under the prefix ghcr.io/grafana/operator. This might be confusing since Grafana has other operators (which are not hosted on ghcr.io, AFAIK, so there is no conflict yet). Still, it's best if we change the prefix for images to something like ghcr.io/grafana/k6-operator.

Once implemented, this change somewhat forces people to adjust their setups around the k6-operator and in their Dockerfiles if they're building from our runner image. So if someone has opinions to share, they're welcome to.

Suggested Solution (optional)

No response

Already existing or connected issues / PRs (optional)

No response
@yorugac yorugac added enhancement New feature or request good first issue Good for newcomers labels Apr 28, 2023
javaducky added a commit that referenced this issue Jul 12, 2023
@javaducky
Update image names to k6-operator over generic operator
8eb109f 
Fixes #221

Signed-off-by: Paul Balogh <javaducky@gmail.com>
@javaducky javaducky mentioned this issue Jul 12, 2023
Merged
yorugac pushed a commit that referenced this issue Jul 17, 2023
@javaducky @yorugac
Update image names to k6-operator over generic operator
42cebe3 
Fixes #221

Signed-off-by: Paul Balogh <javaducky@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update image names to k6-operator over generic operator grafana/k6-operator
1 participant
@yorugac