Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to use a custom Go image to build apps #141

Merged
merged 1 commit into from
Aug 14, 2022

Conversation

danielpalstra
Copy link
Contributor

@danielpalstra danielpalstra commented Aug 10, 2022

This PR adds the ability to build the go app using a custom Go builder image. I use it to be able to build the operator in a corp network.

@danielpalstra danielpalstra marked this pull request as ready for review August 10, 2022 10:35
Copy link
Collaborator

@yorugac yorugac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you!

@yorugac yorugac merged commit 2831aa9 into grafana:main Aug 14, 2022
@yorugac
Copy link
Collaborator

yorugac commented Aug 14, 2022

Additional fix here is in this commit: c7b395e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants