Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for full threshold syntax #176

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

mwain
Copy link
Contributor

@mwain mwain commented Dec 16, 2022

While running some tests the initializer couldn't marshal the full threshold syntax.
Threshold syntax is docs:

export const options = {
  thresholds: {
    metric_name1: ['threshold_expression', `...`], // short format
    metric_name2: [
      {
        threshold: 'threshold_expression',
        abortOnFail: true, // boolean
        delayAbortEval: '10s', // string
      },
    ], // full format
  },
};

This adds support for full and short versions of thresholds using stats.Thresholds

@CLAassistant
Copy link

CLAassistant commented Dec 16, 2022

CLA assistant check
All committers have signed the CLA.

@mwain mwain changed the title Adds support for fullthreshold syntax Adds support for full threshold syntax Dec 16, 2022
@yorugac
Copy link
Collaborator

yorugac commented Jan 20, 2023

Hi @mwain, thank you for the contribution 🙂

Your PR seems fine to me, code-wise 👍 Next week, I'll run a few more tests and if nothing unusual comes up, will merge it in.

Copy link
Collaborator

@yorugac yorugac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants