Scuttle config: change scuttleLogging to disableLogging #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorugac
added
the
breaking change
|
Fixes #179 |
This was referenced Jan 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scuttle logging is enabled by default:
https://github.com/redboxllc/scuttle/blob/1c2b697935c10ef4b3e5e0dc0cf573a4d8766269/scuttle_config.go#L31
So the setting for it should be "disable logging" instead of "enable logging" as it has been so far.
This is a breaking change for those who rely on
scuttleconfiguration.This PR also contains cleaned up manifests (after
make manifests) as it appears some of previous changes weren't properly applied before.