Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Mihail Stoykov <312246+mstoykov@users.noreply.github.com>
  • Loading branch information
codebien and mstoykov committed Aug 16, 2023
1 parent 4c6c52e commit 02dd442
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/executors.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ type ExecutionStep struct {

// ExecutorConfig is an interface that should be implemented by all executor config types
//

Check failure on line 58 in lib/executors.go

View workflow job for this annotation

GitHub Actions / lint

File is not `gofumpt`-ed (gofumpt)
// nolint: interfacebloat
//nolint:interfacebloat

Check failure on line 59 in lib/executors.go

View workflow job for this annotation

GitHub Actions / lint

File is not `gofmt`-ed with `-s` (gofmt)
// At the moment we don't plan to split it. If a need will be raised then we may re-evaluate it.
type ExecutorConfig interface {
Validate() []error
Expand Down
2 changes: 1 addition & 1 deletion lib/runner.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ type VUActivationParams struct {
// TODO: Rename this to something more obvious? This name made sense a very long
// time ago.
//
// nolint: interfacebloat
//nolint:interfacebloat

Check failure on line 50 in lib/runner.go

View workflow job for this annotation

GitHub Actions / lint

File is not `gofmt`-ed with `-s` (gofmt)
// We may evaluate in the future if we can move out some methods;
// but considering how central it is, it would require a huge effort.
type Runner interface {
Expand Down

0 comments on commit 02dd442

Please sign in to comment.